resolves #481, #301 encode anchors containing characters outside ASCII range in hex #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mojavelinux
commented
Aug 7, 2016
•
mojavelinux
commented
- hex encode anchors that contain characters outside the ASCII range
- squelch the following warning: regexp match /.../n against to UTF-8 string (pdf-core < 0.6.1)
|
Technically, the cross references work when using pdf-core 0.6.1. However, since the file stream is written in binary encoding (ASCII-8BIT), it's best that all raw strings be encoded into an ASCII compatible string. Otherwise, the characters are very cryptic when looking at the raw PDF source and thus hard to analyze and test. |
|
Use the following to unencode references in the PDF source that begin with 0x. |
…haracters outside ASCII range in hex - hex encode anchors that contain characters outside the ASCII range - squelch the following warning: regexp match /.../n against to UTF-8 string (pdf-core < 0.6.1)
fapdash
pushed a commit
to vogellacompany/asciidoctor-pdf
that referenced
this pull request
Dec 13, 2016
…haracters outside ASCII range in hex (PR asciidoctor#499) - hex encode anchors that contain characters outside the ASCII range - squelch the following warning: regexp match /.../n against to UTF-8 string (pdf-core < 0.6.1)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.