theme: Allow custom page size setting #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice improvement! I have one suggestion. Could you write the assignment as follows? pdf_opts[:page_size] = pdf_opts[:page_size].upcase if ::String === pdf_opts[:page_size]In Ruby, |
To allow a custom page size to be used, we need to check if the argument passed in the theme is a String, for which we ought to upcase to use in Prawn converted, or keep the custom value to be passed over it. This has been tested using a custom theme with: ,---- | ... | page: | ... | size: [508, 635] | ... | ... `---- Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
This partially addresses #65. I say partially because it must be set in the theme file rather than the document, so we'll still need a change to allow it to be set in by the document. |
|
This looks great @otavio! Thanks! |
mojavelinux
added a commit
that referenced
this pull request
May 13, 2015
theme: Allow custom page size setting
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow a custom page size to be used, we need to check if the
argument passed in the theme is a String, for which we ought to upcase
to use in Prawn converted, or keep the custom value to be passed over
it.
This has been tested using a custom theme with:
,----
| ...
| page:
| ...
| size: [508, 635]
| ...
| ...
`----
Signed-off-by: Otavio Salvador otavio@ossystems.com.br