Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Don't check MSRV for ash-examples #874

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Conversation

Friz64
Copy link
Contributor

@Friz64 Friz64 commented Mar 13, 2024

ash-examples has a lot of dependencies (mostly through winit), and so it's not unlikely for it to break the MSRV check. Here's the current CI error:

error: package `half v2.4.0` cannot be built because it requires rustc 1.70 or newer, while the currently active rustc version is 1.69.0
Either upgrade to rustc 1.70 or newer, or use
cargo update -p half@2.4.0 --precise ver
where `ver` is the latest version of `half` supporting rustc 1.69.0

It doesn't make much sense to have our MSRV influenced by it IMO.

Copy link
Collaborator

@MarijnS95 MarijnS95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1c9e422 don't think there was a compelling reason back then, besides "it adheres to it now".

@MarijnS95 MarijnS95 merged commit 1eb8725 into ash-rs:master Mar 13, 2024
10 checks passed
@Friz64 Friz64 deleted the fix-msrv-ci branch March 13, 2024 21:49
@MarijnS95
Copy link
Collaborator

Turns out I intended to land this via #799 in c3d2dd1 too :)

@MarijnS95 MarijnS95 added this to the Ash 0.38 milestone Dec 3, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants