Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Multiple @implements in single .cshtml #16084

Closed
DNF-SaS opened this issue May 3, 2018 · 4 comments
Closed

Multiple @implements in single .cshtml #16084

DNF-SaS opened this issue May 3, 2018 · 4 comments
Assignees
Labels
area-blazor Includes: Blazor, Razor Components

Comments

@DNF-SaS
Copy link

DNF-SaS commented May 3, 2018

Like

@implements IEventListener
@implements IDisposable

the resulting code should be like

public class MyClass: Microsoft.AspNetCore.Blazor.Components.BlazorComponent, IEventListener, IDisposable

but is only
public class MyClass: Microsoft.AspNetCore.Blazor.Components.BlazorComponent, IEventListener

@aguacongas
Copy link
Contributor

aguacongas commented May 4, 2018

BlazorComponent implements IComponent
IComponent extends IDisposable
You don't have to implements IDisposable

@DNF-SaS
Copy link
Author

DNF-SaS commented May 4, 2018

@aguacongas did this change in the last few weeks?

@rynowak
Copy link
Member

rynowak commented May 4, 2018

I'll take a look at this. Even if it's not necessary, the generated code should still do what you say 👍

@rynowak rynowak self-assigned this May 4, 2018
rynowak referenced this issue in dotnet/blazor May 8, 2018
The pass for this was 'break'ing after the first directive for no real
reason. Oops.
@rynowak
Copy link
Member

rynowak commented May 8, 2018

This is fixed now in dev and will be included in 0.4

SteveSandersonMS referenced this issue in SteveSandersonMS/BlazorMigration Nov 27, 2018
The pass for this was 'break'ing after the first directive for no real
reason. Oops.
@mkArtakMSFT mkArtakMSFT transferred this issue from dotnet/blazor Oct 27, 2019
@mkArtakMSFT mkArtakMSFT added the area-blazor Includes: Blazor, Razor Components label Oct 27, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 4, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Development

No branches or pull requests

4 participants