Skip to content

Remove en-us from link #2006

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Dec 27, 2019
Merged

Remove en-us from link #2006

merged 1 commit into from
Dec 27, 2019

Conversation

roji
Copy link
Member

@roji roji commented Dec 20, 2019

No description provided.

@@ -128,7 +128,7 @@ Easily perform temporal queries on your favourite database using introduced exte

### EFCore.TimeTraveler

Allow full-featured Entity Framework Core queries against [SQL Server Temporal History](https://docs.microsoft.com/en-us/sql/relational-databases/tables/temporal-table-usage-scenarios?view=sql-server-ver15#point-in-time-analysis-time-travel) using the EF Core code, entities, and mappings you already have defined. Travel through time by wrapping your code in `using (TemporalQuery.AsOf(targetDateTime)) {...}`. For EF Core: 3.
Allow full-featured Entity Framework Core queries against [SQL Server Temporal History](https://docs.microsoft.com/sql/relational-databases/tables/temporal-table-usage-scenarios?view=sql-server-ver15#point-in-time-analysis-time-travel) using the EF Core code, entities, and mappings you already have defined. Travel through time by wrapping your code in `using (TemporalQuery.AsOf(targetDateTime)) {...}`. For EF Core: 3.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense @smitpatel, thanks. Should we put the linking guidelines somewhere in the contribution guide?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Also removed the explicit linking to SQL Server 15 (now it just goes to the latest).

@roji roji force-pushed the RemoveAnnoyingEnUs branch from 4c41b88 to 7af64ac Compare December 20, 2019 22:35
@roji roji force-pushed the RemoveAnnoyingEnUs branch from 7af64ac to a4e1cee Compare December 21, 2019 09:33
@roji roji merged commit 2ecb801 into master Dec 27, 2019
@smitpatel smitpatel deleted the RemoveAnnoyingEnUs branch February 5, 2020 16:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants