Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Server is showing outdated syntax errors #495

Closed
vikigenius opened this issue Sep 16, 2024 · 5 comments · Fixed by astral-sh/ruff#13407
Closed

Server is showing outdated syntax errors #495

vikigenius opened this issue Sep 16, 2024 · 5 comments · Fixed by astral-sh/ruff#13407
Labels
bug Something isn't working

Comments

@vikigenius
Copy link

I filed an issue report on emacs-lsp but I was wondering if this is a ruff-issue because I only started seeing it after 0.0.54

Syntax-errors show up as I type but don't go away after I save. I have to restart the server for them to go away.

emacs-lsp/lsp-mode#4547

@vikigenius
Copy link
Author

I think the issue is that Emacs lsp-mode switched their client to ruff server instead of ruff-lsp. So the issue could be on their side or could be with ruff server.

So it probably doesn't belong here. I am going to create an issue on the ruff repo instead

@MichaReiser
Copy link
Member

Hi @vikigenius

I'm not using emacs myself but I gave it a quick try in VS code and lint and syntax diagnostics correctly refresh when I type.

Do you observe this issue only with syntax or both for syntax and lint errors?

One difference between ruff-lsp and ruff server is that the latter uses pull diagnostics when available. Maybe emacs-lsp isn't pulling the new diagnostics as you type?

@MichaReiser MichaReiser added the question Further information is requested label Sep 17, 2024
@vikigenius
Copy link
Author

@MichaReiser you can follow the discussion on the linked issue. But here are the IO logs between the server and client

ruff-io-log.txt

Does this seem right to you?

@MichaReiser
Copy link
Member

I'll comment in the linked issue so that the entire conversation happens in one place.

@MichaReiser MichaReiser added bug Something isn't working and removed question Further information is requested labels Sep 19, 2024
@MichaReiser
Copy link
Member

Note: This is a bug in ruff server and not ruff lsp but I don't think it's worth moving the issue now where it is already linked in several places.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants