Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

ruff's --fix returns a non-zero exit code even though there's only one fixable lint error. #341

Closed
snapdgn opened this issue Oct 7, 2022 · 2 comments · Fixed by #342
Closed

ruff's --fix returns a non-zero exit code even though there's only one fixable lint error. #341

snapdgn opened this issue Oct 7, 2022 · 2 comments · Fixed by #342
Assignees
@charliermarsh

Comments

@snapdgn
Copy link

snapdgn commented Oct 7, 2022

code snippet to reproduce the issue:

import json

def fn():
    pass

command: ruff . --fix

output: No pyproject.toml found. Falling back to default configuration... Found 0 error(s) (1 fixed).

echo $? gives 1(as exit code)

Image for reference:
image
@charliermarsh
Copy link
Member

Oh thanks! Will fix.

@charliermarsh charliermarsh self-assigned this Oct 7, 2022
@cnpryer cnpryer mentioned this issue Oct 7, 2022
Merged
@charliermarsh charliermarsh mentioned this issue Oct 7, 2022
Merged
@charliermarsh
Copy link
Member

v0.0.58 is building now.

@snapdgn snapdgn changed the title ruff's --fix return a non-zero exit code even though there's only one fixable lint error. ruff's --fix returns a non-zero exit code even though there's only one fixable lint error. Oct 7, 2022
@stefanv stefanv mentioned this issue Feb 7, 2023
Closed
@codegrande codegrande mentioned this issue May 17, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@charliermarsh charliermarsh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exit 0 if all errors are fixed astral-sh/ruff
2 participants
@charliermarsh @snapdgn