Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

uv fails to compile proper --universal txt file with openai-whisper #6852

Closed
stasbel opened this issue Aug 30, 2024 · 6 comments
Closed

uv fails to compile proper --universal txt file with openai-whisper #6852

stasbel opened this issue Aug 30, 2024 · 6 comments
Labels
question Asking for clarification or support

Comments

@stasbel
Copy link

stasbel commented Aug 30, 2024

platform: macos
version: 0.4.0

openai-whisper has following dependency:

triton>=2.0.0,<3;platform_machine=="x86_64" and sys_platform=="linux" or sys_platform=="linux2"

however, running uv pip compile with --universal on macos does't preserve platform tags
what you can see in the output is plain:

triton==2.0.0

this results in inability to install packages on macos

@charliermarsh
Copy link
Member

Do you mind including the full command you ran to reproduce?

@charliermarsh charliermarsh added the question Asking for clarification or support label Aug 30, 2024
@stasbel
Copy link
Author

stasbel commented Aug 30, 2024

sure

reqs.in

openai-whisper==20231117

command

uv pip compile --no-strip-extras --universal reqs.in -o reqs.txt

@stasbel
Copy link
Author

stasbel commented Aug 30, 2024

if I insert platform tags to .txt file manually after, everything works fine :)

@charliermarsh
Copy link
Member

I think this is an issue with openai-whisper. See: https://github.com/openai/whisper/blob/ba3f3cd54b0e5b8ce1ab3de13e32122d0d5f98ab/setup.py#L15, which does:

requirements = []
if sys.platform.startswith("linux") and platform.machine() == "x86_64":
    requirements.append("triton>=2.0.0,<3")

They should apply those constraints as environment markers, they shouldn't depend on the host machine... I can file a PR.

@charliermarsh
Copy link
Member

Actually confused because that variable isn't even used.

@charliermarsh
Copy link
Member

Ah ok, unfortunately this change is unreleased: openai/whisper#1887. You'll have to use:

openai-whisper @ git+https://github.com/openai/whisper.git@ba3f3cd54b0e5b8ce1ab3de13e32122d0d5f98ab

In order to access it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
question Asking for clarification or support
Projects
None yet
Development

No branches or pull requests

2 participants