Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat!: release 1.0.0 without CLI #134

Merged
merged 2 commits into from
Jun 27, 2022
Merged

feat!: release 1.0.0 without CLI #134

merged 2 commits into from
Jun 27, 2022

Conversation

magicmatatjahu
Copy link
Member

Description

  • remove cli from repo - adjust CLI section writing how to use official CLI with convert command
  • remove old id option - we don't need that, so we can remove it by releasing 1.0.0
  • update unit tests

I think that this project is mature, so we can release first major version.

cc @derberg @fmvilas

Related issue(s)
Resolves #109

@magicmatatjahu magicmatatjahu added the enhancement New feature or request label Jun 14, 2022
@magicmatatjahu
Copy link
Member Author

@derberg ping, ping :)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@derberg derberg changed the title feat!: release 1.0.0 feat!: release 1.0.0 without CLI Jun 27, 2022
derberg
derberg approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I only adjusted PR title so it is clear in the release what is this release doing as a breaking change, without opening the PR

@magicmatatjahu
Copy link
Member Author

@derberg Thanks!

@magicmatatjahu
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit f2ee74e into asyncapi:master Jun 27, 2022
@magicmatatjahu magicmatatjahu deleted the release-1.0.0 branch June 27, 2022 10:00
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@derberg derberg derberg approved these changes

@fmvilas fmvilas Awaiting requested review from fmvilas fmvilas is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request ready-to-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removing the CLI
3 participants
@magicmatatjahu @asyncapi-bot @derberg