Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Draft] Update on script npm run generator:test:cli #1369

Open
Adi-204 opened this issue Feb 20, 2025 · 5 comments
Open

[Draft] Update on script npm run generator:test:cli #1369

Adi-204 opened this issue Feb 20, 2025 · 5 comments

Comments

@Adi-204
Copy link
Contributor

Adi-204 commented Feb 20, 2025

While running npm run generator:test:cli the script does not throw any errors but results in the following output:

Image

The last package update introduced the deprecation of ag. If no task are executed by the script should we proceed with removing this script from package.json and the documentation, or are there any team discussions/plans regarding this?
Please provide feedback and explanation.

@Adi-204
Copy link
Contributor Author

Adi-204 commented Feb 20, 2025

@derberg sir can you please provide feedback thanks : )

Copy link
Member

derberg commented Feb 20, 2025

hey, the fact that we deprecated cli do not mean it is removed - cli test should be invoked - it is simple cli run - but should run afaik. Did you try to investigate why it doesn't run? maybe we have an error in turborepo config?

@Adi-204
Copy link
Contributor Author

Adi-204 commented Feb 20, 2025

Copy link
Member

derberg commented Feb 20, 2025

ah, ok, as it was using the deprecated CLI
we probably need to figure how to do this using AsyncAPI CLI, maybe with npx 🤔

@Adi-204
Copy link
Contributor Author

Adi-204 commented Feb 21, 2025

@derberg Sir, could you please provide more details about the approach so that I can add value in resolving the issue?
From my understanding, the cli.js file contains code for the deprecated ag CLI, and we have now transitioned to the AsyncAPI CLI. This implies that we are no longer directly testing the cli.js file. Instead, are we planning to run tests directly on the AsyncAPI CLI, as shown below?
"test:cli": "npx @asyncapi/cli ..."
However, this approach does not actually test the code of cli.js file.
Could you please explain thanks : )

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants