From 46d4bd4e8b66ba4947c526c6b37dd444c085bfae Mon Sep 17 00:00:00 2001
From: Adam Chalkley <atc0005@users.noreply.github.com>
Date: Mon, 12 Feb 2024 06:20:22 -0600
Subject: [PATCH] Fix linting error and potential race condition

Fix revive `unused-parameter` linting error caused by
unintentional use of a variable from the goroutine's parent
scope.

refs GH-764
---
 cmd/certsum/certcheck.go | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/cmd/certsum/certcheck.go b/cmd/certsum/certcheck.go
index c9aabbf2..2661a9c3 100644
--- a/cmd/certsum/certcheck.go
+++ b/cmd/certsum/certcheck.go
@@ -194,7 +194,7 @@ func certScanner(
 
 				go func(
 					ctx context.Context,
-					portscanResult netutils.PortCheckResult,
+					psResult netutils.PortCheckResult,
 					timeout time.Duration,
 					resultsChan chan<- certs.DiscoveredCertChain,
 					log zerolog.Logger,
@@ -228,9 +228,9 @@ func certScanner(
 
 					var certFetchErr error
 					log.Debug().
-						Str("host", portScanResult.Host).
-						Str("ip_address", portScanResult.IPAddress.String()).
-						Int("port", portScanResult.Port).
+						Str("host", psResult.Host).
+						Str("ip_address", psResult.IPAddress.String()).
+						Int("port", psResult.Port).
 						Msg("Retrieving certificate chain")
 
 					// NOTE: We explicitly specify the IP Address to prevent
@@ -239,9 +239,9 @@ func certScanner(
 					// of using a name/FQDN to open the connection) to
 					// retrieve the certificate chain.
 					certChain, certFetchErr := netutils.GetCerts(
-						portScanResult.Host,
-						portScanResult.IPAddress.String(),
-						portScanResult.Port,
+						psResult.Host,
+						psResult.IPAddress.String(),
+						psResult.Port,
 						timeout,
 						log,
 					)
@@ -253,9 +253,9 @@ func certScanner(
 						}
 						log.Error().
 							Err(certFetchErr).
-							Str("host", portScanResult.Host).
-							Str("ip_address", portScanResult.IPAddress.String()).
-							Int("port", portScanResult.Port).
+							Str("host", psResult.Host).
+							Str("ip_address", psResult.IPAddress.String()).
+							Int("port", psResult.Port).
 							Msg("error fetching certificates chain")
 
 						// os.Exit(1)
@@ -266,9 +266,9 @@ func certScanner(
 
 					log.Debug().Msg("Attempting to send cert chain on resultsChan")
 					resultsChan <- certs.DiscoveredCertChain{
-						Name:      portScanResult.Host,
-						IPAddress: portScanResult.IPAddress.String(),
-						Port:      portScanResult.Port,
+						Name:      psResult.Host,
+						IPAddress: psResult.IPAddress.String(),
+						Port:      psResult.Port,
 						Certs:     certChain,
 					}