-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Remove {styler} dependency #140
Comments
@atorus-research/xportr-development-team shall we remove the styler dependency in We have it in our pipelines already - maybe a note around this in our wiki? |
I think we can remove it from Suggests and add an installation step for styler in the CI pipeline. WDYT? |
Yes lets remove it. |
Thanks guys for the prompt reaction 👍 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Hi, author of the formatting package {styler} here. As I judge from a search in your source code, there is no functionality that uses {styler}, in other words {styler} is not a runtime dependency. You recommend people to format their code when they contribute, so {styler} is a development dependency. Adding {styler} as a dependency to your package has the following drawbacks:
For that reason, I suggest you to drop that dependency from your package. If you want to ensure your code remains styled, I recommend {precommit} to apply {styler} on each commit or other tools described in the third-party integrations website of {styler}.
For the removal to take effect, a CRAN submission of your package is required. For tracking, this issue is referenced in r-lib/styler#1121.
The text was updated successfully, but these errors were encountered: