Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Made changes to my fork of this repo to make it compatible with PHP 8.1 #22

Open
rotexdegba opened this issue Feb 7, 2024 · 1 comment

Comments

@rotexdegba
Copy link

rotexdegba commented Feb 7, 2024

I have been using this package in some applications running in a PHP 7.4 environment. When I upgraded to PHP 8.1 and ran the applications I got the following deprecation warnings:

PHP Deprecated:  strtoupper(): Passing null to parameter #1 ($string) of type string is deprecated in C:\SoftwareProjects\test-php-project\vendor\aura\sqlschema\src\MysqlSchema.php on line 121

Deprecated: strtoupper(): Passing null to parameter #1 ($string) of type string is deprecated in C:\SoftwareProjects\test-php-project\vendor\aura\sqlschema\src\MysqlSchema.php on line 121
PHP Deprecated:  strtoupper(): Passing null to parameter #1 ($string) of type string is deprecated in C:\SoftwareProjects\test-php-project\vendor\aura\sqlschema\src\MysqlSchema.php on line 121

Deprecated: strtoupper(): Passing null to parameter #1 ($string) of type string is deprecated in C:\SoftwareProjects\test-php-project\vendor\aura\sqlschema\src\MysqlSchema.php on line 121
PHP Deprecated:  strtoupper(): Passing null to parameter #1 ($string) of type string is deprecated in C:\SoftwareProjects\test-php-project\vendor\aura\sqlschema\src\MysqlSchema.php on line 121

Deprecated: strtoupper(): Passing null to parameter #1 ($string) of type string is deprecated in C:\SoftwareProjects\test-php-project\vendor\aura\sqlschema\src\MysqlSchema.php on line 121
PHP Deprecated:  strtoupper(): Passing null to parameter #1 ($string) of type string is deprecated in C:\SoftwareProjects\test-php-project\vendor\aura\sqlschema\src\MysqlSchema.php on line 121

Deprecated: strtoupper(): Passing null to parameter #1 ($string) of type string is deprecated in C:\SoftwareProjects\test-php-project\vendor\aura\sqlschema\src\MysqlSchema.php on line 121
PHP Deprecated:  strtoupper(): Passing null to parameter #1 ($string) of type string is deprecated in C:\SoftwareProjects\test-php-project\vendor\aura\sqlschema\src\MysqlSchema.php on line 121

Deprecated: strtoupper(): Passing null to parameter #1 ($string) of type string is deprecated in C:\SoftwareProjects\test-php-project\vendor\aura\sqlschema\src\MysqlSchema.php on line 121
PHP Deprecated:  strtoupper(): Passing null to parameter #1 ($string) of type string is deprecated in C:\SoftwareProjects\test-php-project\vendor\aura\sqlschema\src\MysqlSchema.php on line 121

Deprecated: strtoupper(): Passing null to parameter #1 ($string) of type string is deprecated in C:\SoftwareProjects\test-php-project\vendor\aura\sqlschema\src\MysqlSchema.php on line 121
PHP Deprecated:  strtoupper(): Passing null to parameter #1 ($string) of type string is deprecated in C:\SoftwareProjects\test-php-project\vendor\aura\sqlschema\src\MysqlSchema.php on line 121

Deprecated: strtoupper(): Passing null to parameter #1 ($string) of type string is deprecated in C:\SoftwareProjects\test-php-project\vendor\aura\sqlschema\src\MysqlSchema.php on line 121
PHP Deprecated:  strtoupper(): Passing null to parameter #1 ($string) of type string is deprecated in C:\SoftwareProjects\test-php-project\vendor\aura\sqlschema\src\MysqlSchema.php on line 121

Deprecated: strtoupper(): Passing null to parameter #1 ($string) of type string is deprecated in C:\SoftwareProjects\test-php-project\vendor\aura\sqlschema\src\MysqlSchema.php on line 121

So I decided to fork this project and created a new branch rotexsoft/Aura.SqlSchema@2.x...3.0.1 in my fork that makes the code compatible with PHP 8.1 & also made it support mariadb & Postgres (which doesn't work on the latest version 2.0.3). Details of the changes I made can be found here https://github.com/rotexdegba/Aura.SqlSchema/releases

If accepted, these changes should be merged into a 3.x branch and a new 3.0.0 major release should be created.

Looking forward to hearing back from you.

If I don't hear back by the end of this week (Sunday Feb 11, 2024), I will just go ahead to create a new package on packagist from my fork & just adjust the namespaces, because I really need these changes in an application that I will be updating to PHP 8.1 in production. I have tried to look for an email address for Paul Jones or Hari K T but couldn't find any and I could not post to the Google group it seems to have posting disabled or maybe because I just joined the group.

Thanks.

@rotexdegba
Copy link
Author

I have decided to fork this package. This fork works with MariaDB & is no longer compatible with this package.

Fork https://packagist.org/packages/rotexsoft/sqlschema

Diff rotexsoft/Aura.SqlSchema@2.x...rotexsoft-3.x

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant