Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Globs doesn't include bower images #33

Closed
alexandcote opened this issue Apr 4, 2015 · 0 comments
Closed

Globs doesn't include bower images #33

alexandcote opened this issue Apr 4, 2015 · 0 comments

Comments

@alexandcote
Copy link
Contributor

When the bower dependencies have images, the "buildGlobs" doesn't fetch it correctly.

Here is my manifest.json

{
  "dependencies": {
    "app.js": {
      "files": [
        "scripts/app.js"
      ],
      "main": true
    },
    "main.css": {
      "files": [
        "styles/main.scss"
      ],
      "main": true
    },
    "jquery.js": {
      "bower": ["jquery"]
    },
    "bxslider.js": {
      "bower": ["bxslider-4"]
    },
    "bxslider.css": {
      "bower": ["bxslider-4"]
    },
    "fonts": {
      "files": ["fonts/**/*"]
    },
    "images": {
      "files": ["images/**/*"],
      "bower": ["bxslider-4"]
    }
  },
  "config": {
    "url": "url.dev"
  }
}

and this is a part of my bower.json

"dependencies": {
    "jquery": "~1.11.2",
    "bootstrap-sass-official": "~3.3.4",
    "bxslider-4": "~4.2.3"
  },
  "overrides": {
    "bxslider-4": {
      "main":[
        "./dist/jquery.bxslider.min.js",
        "./dist/jquery.bxslider.css",
        "./dist/images/bx_loader.gif",
        "./dist/images/controls.png"
      ]
    },
    "bootstrap-sass-official": {
      "main": [
        "./assets/stylesheets/_bootstrap.scss",
        "./assets/javascripts/bootstrap/transition.js",
        "./assets/javascripts/bootstrap/alert.js",
        "./assets/javascripts/bootstrap/button.js",
        "./assets/javascripts/bootstrap/carousel.js",
        "./assets/javascripts/bootstrap/collapse.js",
        "./assets/javascripts/bootstrap/dropdown.js",
        "./assets/javascripts/bootstrap/modal.js",
        "./assets/javascripts/bootstrap/tooltip.js",
        "./assets/javascripts/bootstrap/popover.js",
        "./assets/javascripts/bootstrap/scrollspy.js",
        "./assets/javascripts/bootstrap/tab.js",
        "./assets/javascripts/bootstrap/affix.js",
        "./assets/fonts/bootstrap/glyphicons-halflings-regular.eot",
        "./assets/fonts/bootstrap/glyphicons-halflings-regular.svg",
        "./assets/fonts/bootstrap/glyphicons-halflings-regular.ttf",
        "./assets/fonts/bootstrap/glyphicons-halflings-regular.woff",
        "./assets/fonts/bootstrap/glyphicons-halflings-regular.woff2"
      ]
    }
  }

When I print out the array of the globs, I got

{ 
config: { url: "url.dev" },
  dependencies:
   { fonts: { files: [Object] },
     images: { files: [Object], bower: [Object] },
     "app.js": { files: [Object], main: [Object] },
     "main.css": { files: [Object], main: [Object] },
     "jquery.js": { bower: [Object], files: [] },
     "bxslider.js": { bower: [Object], files: [] },
     "bxslider.css": { bower: [Object], files: [] } },
  globs:
   { js: [ [Object], [Object], [Object] ],
     css: [ [Object], [Object] ],
     fonts:
      [ "bootstrap-sass-official/assets/fonts/bootstrap/glyphicons-halflings-regular.eot",
        "bootstrap-sass-official/assets/fonts/bootstrap/glyphicons-halflings-regular.svg",
        "bootstrap-sass-official/assets/fonts/bootstrap/glyphicons-halflings-regular.ttf",
        "bootstrap-sass-official/assets/fonts/bootstrap/glyphicons-halflings-regular.woff",
        "bootstrap-sass-official/assets/fonts/bootstrap/glyphicons-halflings-regular.woff2",
        "assets/fonts/**/*" ],
     images: [ "assets/images/**/*" ],
     bower:
      [ "jquery/dist/jquery.js",
        "bootstrap-sass-official/assets/stylesheets/_bootstrap.scss",
        "bootstrap-sass-official/assets/javascripts/bootstrap/transition.js",
        "bootstrap-sass-official/assets/javascripts/bootstrap/alert.js",
        "bootstrap-sass-official/assets/javascripts/bootstrap/button.js",
        "bootstrap-sass-official/assets/javascripts/bootstrap/carousel.js",
        "bootstrap-sass-official/assets/javascripts/bootstrap/collapse.js",
        "bootstrap-sass-official/assets/javascripts/bootstrap/dropdown.js",
        "bootstrap-sass-official/assets/javascripts/bootstrap/modal.js",
        "bootstrap-sass-official/assets/javascripts/bootstrap/tooltip.js",
        "bootstrap-sass-official/assets/javascripts/bootstrap/popover.js",
        "bootstrap-sass-official/assets/javascripts/bootstrap/scrollspy.js",
        "bootstrap-sass-official/assets/javascripts/bootstrap/tab.js",
        "bootstrap-sass-official/assets/javascripts/bootstrap/affix.js",
        "bootstrap-sass-official/assets/fonts/bootstrap/glyphicons-halflings-regular.eot",
        "bootstrap-sass-official/assets/fonts/bootstrap/glyphicons-halflings-regular.svg",
        "bootstrap-sass-official/assets/fonts/bootstrap/glyphicons-halflings-regular.ttf",
        "bootstrap-sass-official/assets/fonts/bootstrap/glyphicons-halflings-regular.woff",
        "bootstrap-sass-official/assets/fonts/bootstrap/glyphicons-halflings-regular.woff2",
        "bxslider-4/dist/jquery.bxslider.min.js",
        "bxslider-4/dist/jquery.bxslider.css",
        "bxslider-4/dist/images/bx_loader.gif",
        "bxslider-4/dist/images/controls.png" ] },
  paths: { source: "assets/", dist: "dist/" } }

Thanks a lot for your help

Nice job by the way !! 👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants