Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Issues ready to merge #26

Merged
merged 23 commits into from
Oct 29, 2014
Merged

Issues ready to merge #26

merged 23 commits into from
Oct 29, 2014

Conversation

glena
Copy link
Contributor

@glena glena commented Oct 15, 2014

Ready on dev: #5, #11, #18 & #22 waiting for merge.
I would be great if you can add a new label "ready"

@glena
Copy link
Contributor Author

glena commented Oct 16, 2014

Updated issue #5 (change the way we show the widget, check the registration settings to avoid new accounts are created on social login, fixes several issues related to social registration - ie: with twitter or facebook accounts when there is no email).
issue #11 (now it handle errors when we receive an error or error_message instead of code param)
issue #18 (no comments related to this issue)
issue #22 (moved to an Auth0 specific section instead on general settings)

@mgonto
Copy link
Contributor

mgonto commented Oct 27, 2014

Some issues I've found:

After this, let's merge :).

Cheers!

@glena
Copy link
Contributor Author

glena commented Oct 27, 2014

  • Logo: seems that is issue is because the plugin was saved into a directory called wp-auth0-dev instead of wp-auth0. Did you change it? I will change it anyway so it is relative to the wp-auth0 directory instad of the plugins one.
  • "Changes saved" Label: done
  • Error message: done
  • Widget config: done, and added the extra enter to the 3 configurations with radio buttons (It depends on your viewport size how it is shown so I change all of them).

@mgonto
Copy link
Contributor

mgonto commented Oct 29, 2014

This looks good now :).

Let me first see the CSS one.

 Add option to enter custom CSS #21
mgonto added a commit that referenced this pull request Oct 29, 2014
Issues ready to merge
@mgonto mgonto merged commit d6d5fa0 into master Oct 29, 2014
@mgonto mgonto deleted the dev branch October 29, 2014 14:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants