Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixed automatic setup process for public sites #370

Merged
merged 1 commit into from
Jan 24, 2018

Conversation

joshcanhelp
Copy link
Contributor

Main goal here is moving from storing the API audience from the API token to creating a settings field to hold one with the system Management API audience (most likely to be used in the vast majority of installs) as a default.

Also:

  • Fixed up WP_Auth0_Api_Client::get_client_token() do use recommended Content-Type header
  • Updated 2 docs links, relevant to the updates in this release
  • Removed empty cache_expiration setting check (can be 0 for no caching)
  • Added client update procedure from DB v15 to DB v16 to catch site_url() update

@joshcanhelp joshcanhelp requested a review from cocojoe January 24, 2018 16:21
@joshcanhelp joshcanhelp added this to the v3-Next milestone Jan 24, 2018
…tings field that defaults to system Management API audience if blank; updating docs links; adding client update procedure from DB v15 to DB v16; adding new scopes to consent process to create client grant
@joshcanhelp joshcanhelp force-pushed the fixed-auto-setup-process branch from 5ee767f to 79a9442 Compare January 24, 2018 17:38
@cocojoe cocojoe changed the title Fixing automatic setup process for public sites Fixed automatic setup process for public sites Jan 24, 2018
Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshcanhelp joshcanhelp merged commit 28a97a8 into dev Jan 24, 2018
@joshcanhelp joshcanhelp deleted the fixed-auto-setup-process branch January 24, 2018 18:26
@cocojoe cocojoe mentioned this pull request Jan 25, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants