Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Spanish translation by Carlos Longarela #526

Merged
merged 14 commits into from
Dec 3, 2018

Conversation

CarlosLongarela
Copy link
Contributor

Spanish translation commented on forum https://wordpress.org/support/topic/translation-911/

@joshcanhelp joshcanhelp requested a review from lbalmaceda August 22, 2018 14:14
@joshcanhelp joshcanhelp added this to the v3-Next milestone Aug 22, 2018
@joshcanhelp joshcanhelp changed the base branch from dev to master October 2, 2018 17:15
@joshcanhelp
Copy link
Contributor

@CarlosLongarela - Apologies for the delay on reviewing this. I had a number of updates in this upcoming release and still need to get this reviewed on our end. #561 has updates to the translation file and that will be merged here in the next day or so. You'll also need to rebase this with master (should be easy, just toss all of the conflicts in your branch) or create a new PR against master with the updated mo/pot files (copy the ones you have, already, create a new branch from master, add these files, add missing translations, and create a new PR).

Thank you again!

@joshcanhelp
Copy link
Contributor

@CarlosLongarela - The other PR is now merged so POT and English translation are up-to-date and unlikely to change before the next minor release.

@joshcanhelp
Copy link
Contributor

@CarlosLongarela - Just checking in here ... we're working through the last few changes before testing and release. Are you able to take a look at this in the next week or so? If not, we can push this to the next release but would love to get this in.

Thank you!

@joshcanhelp joshcanhelp removed this from the 3.8.0 milestone Oct 29, 2018
@joshcanhelp joshcanhelp changed the title Spanish translation by Carlos Longarela [WIP] Spanish translation by Carlos Longarela Oct 29, 2018
@lbalmaceda
Copy link
Contributor

@joshcanhelp I see there are no updated for this lately, and a lot of conflicts to fix. Are you willing to update this PR @CarlosLongarela ? Please ping me in that case. I'm happy to give it a detailed review!

@CarlosLongarela
Copy link
Contributor Author

@joshcanhelp I see there are no updated for this lately, and a lot of conflicts to fix. Are you willing to update this PR @CarlosLongarela ? Please ping me in that case. I'm happy to give it a detailed review!

Sorry I was out some time. What must I do?

@joshcanhelp
Copy link
Contributor

@CarlosLongarela - No problem, Carlos, thanks for checking back in.

We need the conflicts fixed before we can review and merge this. Instructions are in a comment above. Let me know if you need any guidance there, happy to help.

@CarlosLongarela
Copy link
Contributor Author

@joshcanhelp please tell me if now is ok

@joshcanhelp
Copy link
Contributor

@CarlosLongarela - Close but there are a couple of files that changed that should not have.

@CarlosLongarela
Copy link
Contributor Author

I see 72 new strings in code, please let me 1 hour for translate it.

@CarlosLongarela
Copy link
Contributor Author

All translated. Is now all ok?

@joshcanhelp
Copy link
Contributor

Thanks so much @CarlosLongarela, I'll assign this for review now!

@joshcanhelp joshcanhelp changed the title [WIP] Spanish translation by Carlos Longarela Spanish translation by Carlos Longarela Nov 20, 2018
@joshcanhelp joshcanhelp added this to the v3-Next-Minor milestone Nov 20, 2018
Translation feedback from our team.
Copy link
Contributor

@joshcanhelp joshcanhelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks once again for all your work here!

@joshcanhelp joshcanhelp merged commit fe60c3c into auth0:master Dec 3, 2018
@CarlosLongarela
Copy link
Contributor Author

Thanks to Auth0 team ;)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants