-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Spanish translation by Carlos Longarela #526
Conversation
…limit; fix offline assets/styles
@CarlosLongarela - Apologies for the delay on reviewing this. I had a number of updates in this upcoming release and still need to get this reviewed on our end. #561 has updates to the translation file and that will be merged here in the next day or so. You'll also need to rebase this with Thank you again! |
@CarlosLongarela - The other PR is now merged so POT and English translation are up-to-date and unlikely to change before the next minor release. |
@CarlosLongarela - Just checking in here ... we're working through the last few changes before testing and release. Are you able to take a look at this in the next week or so? If not, we can push this to the next release but would love to get this in. Thank you! |
@joshcanhelp I see there are no updated for this lately, and a lot of conflicts to fix. Are you willing to update this PR @CarlosLongarela ? Please ping me in that case. I'm happy to give it a detailed review! |
Sorry I was out some time. What must I do? |
@CarlosLongarela - No problem, Carlos, thanks for checking back in. We need the conflicts fixed before we can review and merge this. Instructions are in a comment above. Let me know if you need any guidance there, happy to help. |
@joshcanhelp please tell me if now is ok |
@CarlosLongarela - Close but there are a couple of files that changed that should not have. |
I see 72 new strings in code, please let me 1 hour for translate it. |
All translated. Is now all ok? |
Thanks so much @CarlosLongarela, I'll assign this for review now! |
Translation feedback from our team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks once again for all your work here!
Thanks to Auth0 team ;) |
Spanish translation commented on forum https://wordpress.org/support/topic/translation-911/