Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Deprecate methods in WP_Auth0_Api_Operations and related ones in WP_Auth0 #552

Merged
merged 1 commit into from
Oct 4, 2018

Conversation

joshcanhelp
Copy link
Contributor

Deprecation docblocks and error triggering for unused methods in the WP_Auth0_Api_Operations and WP_Auth0 classes. Also moved all deprecated methods to the bottom of the class.

No functional changes 👍

@joshcanhelp joshcanhelp added this to the v3-Next milestone Oct 2, 2018
@joshcanhelp joshcanhelp force-pushed the deprecate-api-operation-methods branch from 56531e8 to bdd4e71 Compare October 2, 2018 22:52
@codecov-io
Copy link

Codecov Report

Merging #552 into master will increase coverage by 0.3%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #552     +/-   ##
===========================================
+ Coverage     15.36%   15.67%   +0.3%     
+ Complexity     1605     1561     -44     
===========================================
  Files            69       69             
  Lines          5473     5365    -108     
===========================================
  Hits            841      841             
+ Misses         4632     4524    -108
Impacted Files Coverage Δ Complexity Δ
lib/WP_Auth0_Api_Operations.php 0% <0%> (ø) 18 <4> (-44) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 607d9c2...bdd4e71. Read the comment docs.

@joshcanhelp joshcanhelp merged commit 5005b40 into master Oct 4, 2018
@joshcanhelp joshcanhelp deleted the deprecate-api-operation-methods branch October 4, 2018 16:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants