Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update telemetry header #577

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Update telemetry header #577

merged 1 commit into from
Oct 31, 2018

Conversation

joshcanhelp
Copy link
Contributor

Changes

  • Update environment property with env
  • Replace WP_Auth0_Api_Client::get_info_headers() with WP_Auth0_Api_Abstract::get_info_headers()

References

See internal RFC.

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

  • All existing and new tests complete without errors
  • All code quality tools/guidelines in the Contribution guide have been run/followed
  • All active GitHub CI checks have passed

@joshcanhelp joshcanhelp added this to the 3.8.0 milestone Oct 30, 2018
cocojoe
cocojoe approved these changes Oct 31, 2018
View reviewed changes
Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, again maybe add a sample in description or as a comment.

@joshcanhelp joshcanhelp merged commit f86f63c into master Oct 31, 2018
@joshcanhelp joshcanhelp deleted the change-telelmetry-header branch October 31, 2018 16:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@cocojoe cocojoe cocojoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@joshcanhelp @cocojoe