Allow subdomains in redirect and refactor validation tests #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocojoe
reviewed
Dec 13, 2018
| * Test that a subdomain of a main site is valid. | ||
| */ | ||
| public function testThatSubdomainIsValid() { | ||
| $input = [ 'default_login_redirection' => 'https://sub.sub.example.org' ]; |
There was a problem hiding this comment.
was looking for a test like this 👍
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Allow sibling subdomains and other ports of the same domain in the default redirect URL.
References
Internal support request.
Testing