Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove auto-logout; deprecation notice for SSO setting #651

Merged
merged 2 commits into from
Apr 1, 2019

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Mar 29, 2019

Changes

  • Remove auto-logout check when "Single Logout" is turned on. This was causing many, many API calls for dubious utility and prone to confusing behavior.
  • Add Auth0 logout redirect when "Single Logout" is turned on.
  • Add a deprecation notice to "Single Sign-On" referencing the ULP setting. This setting still works as it did before (checkSession call on wp-login.php) but will be removed in the next major.

References

Docs PR commit

@joshcanhelp joshcanhelp added this to the 3.10.0 milestone Mar 29, 2019
@codecov-io
Copy link

codecov-io commented Mar 29, 2019

Codecov Report

Merging #651 into master will decrease coverage by 0.14%.
The diff coverage is 53.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #651      +/-   ##
============================================
- Coverage     42.12%   41.98%   -0.15%     
- Complexity     1238     1241       +3     
============================================
  Files            51       51              
  Lines          3779     3792      +13     
============================================
  Hits           1592     1592              
- Misses         2187     2200      +13
Impacted Files Coverage Δ Complexity Δ
WP_Auth0.php 22.84% <ø> (ø) 62 <0> (ø) ⬇️
lib/WP_Auth0_LoginManager.php 17.73% <0%> (+0.35%) 118 <0> (-2) ⬇️
lib/admin/WP_Auth0_Admin_Features.php 27.81% <88.88%> (+0.86%) 33 <0> (-1) ⬇️
lib/WP_Auth0_Api_Client.php 32.66% <0%> (-2.39%) 77% <0%> (+6%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cab340...8b3388b. Read the comment docs.

@joshcanhelp joshcanhelp force-pushed the change-slo-remove-auto-logout branch from 90bf206 to 95f0ed7 Compare March 30, 2019 16:00
@joshcanhelp joshcanhelp force-pushed the change-slo-remove-auto-logout branch from 95f0ed7 to 4bf0c76 Compare March 30, 2019 16:09
* @return array
*/
function wp_auth0_hook_add_body_class( array $classes ) {
function wp_auth0_filter_body_class( array $classes ) {
Copy link
Contributor Author

@joshcanhelp joshcanhelp Mar 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Public global function but only added a couple of days ago and not released yet.

@joshcanhelp joshcanhelp merged commit bafcddd into master Apr 1, 2019
@joshcanhelp joshcanhelp deleted the change-slo-remove-auto-logout branch April 1, 2019 15:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants