Deprecate WP_Auth0_UsersRepo methods #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #652 +/- ##
============================================
+ Coverage 42.12% 42.44% +0.31%
+ Complexity 1238 1226 -12
============================================
Files 51 51
Lines 3779 3751 -28
============================================
Hits 1592 1592
+ Misses 2187 2159 -28
Continue to review full report at Codecov.
|
cocojoe
reviewed
Apr 1, 2019
| @@ -3,14 +3,14 @@ | |||
| /** | |||
| * Class WP_Auth0_Configure_JWTAUTH | |||
| * | |||
| * @deprecated 3.10.0, plugin is deprecated and removed from the WP plugin repo. | |||
| * @deprecated - 3.10.0, plugin is deprecated and removed from the WP plugin repo. | |||
There was a problem hiding this comment.
Is the - a formatting requirement ? I'll approve anyway, just curious.
There was a problem hiding this comment.
No, just inconsistent with the rest
cocojoe
approved these changes
Apr 1, 2019
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR deprecates the following methods:
WP_Auth0_UsersRepo::init()- still used but will be removed in the next major.WP_Auth0_UsersRepo::getUser()- no longer usedWP_Auth0_UsersRepo::tokenHasRequiredScopes()- no longer used