Fix Auth0 logout redirect #675
Conversation
| $is_slo = (bool) $this->a0_options->get( 'singlelogout' ); | ||
| $is_auto_login = (bool) $this->a0_options->get( 'auto_login' ); | ||
| if ( ! WP_Auth0::ready() ) { | ||
| return; |
There was a problem hiding this comment.
so if you call this when the SDK is not ready (I suppose) this call would return without an error? How can they know they need to wait and retry?
There was a problem hiding this comment.
The ready here is checking if the plugin is configured. If not, then we don't need to do anything during this process.
| $this->assertContains( 'client_id=__test_client_id__', $logout_url_slo['query'] ); | ||
| $this->assertContains( 'returnTo=' . rawurlencode( home_url() ), $logout_url_slo['query'] ); | ||
|
|
||
| // Test that SSO has the same behavior. |
There was a problem hiding this comment.
please move to a different test, even if most of the conditions are shared 👍
There was a problem hiding this comment.
I'm checking against the result of the previous method call, though.
| /** | ||
| * Test that a redirect to the homepage happens if ULP is turned on. | ||
| */ | ||
| public function testThatRedirectHappensIfUlp() { |
There was a problem hiding this comment.
"if ULP is turned on" but I only see you change a "auto-login" parameter. Is the naming correctly?
There was a problem hiding this comment.
Yes. "Auto login" === ULP
Changes
Fix logout redirect if the plugin is not ready (no domain name or client ID)
Testing
Checklist