Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove deprecated basic settings; centralize validation declaration #722

Merged
merged 2 commits into from
Sep 24, 2019

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Sep 5, 2019

Changes

  • Remove deprecated method WP_Auth0_Admin_Basic::render_auth0_app_token()
  • Remove deprecated method WP_Auth0_Admin_Basic::render_allow_#_regular_multisite()
  • Remove deprecated method WP_Auth0_Admin_Basic::render_allow_#_regular()
  • Remove deprecated method WP_Auth0_Admin_Basic::render_basic_description()
  • Remove method WP_Auth0_Admin_Basic::render_auth0_app_token() and replace with wp_auth0_ajax_delete_cache_transient() to handle JWKS delete cache AJAX action.
  • Remove the WP_Auth0_Admin_Basic::BASIC_DESCRIPTION class constant
  • Remove the WP_Auth0_Admin_Features::FEATURES_DESCRIPTION class constant
  • Moved $_description and $actions_middlewares definition to main class

Testing

  • This change adds unit test coverage
  • This change has been tested on WP 5.2.2

@joshcanhelp joshcanhelp added this to the 4.0.0 milestone Sep 5, 2019
@joshcanhelp joshcanhelp marked this pull request as ready for review September 6, 2019 14:01
delete_transient( WPA0_JWKS_CACHE_TRANSIENT_NAME );
wp_send_json_success();
}
add_action( 'wp_ajax_auth0_delete_cache_transient', 'wp_auth0_ajax_delete_cache_transient' );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, it just called exit. Why are you returning json_success now? https://github.com/auth0/wp-auth0/pull/722/files#diff-729ab756a0f851fef2f036fa7ca87b13L351

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wp_send_json_success() is a core WP function that returns a successful response, then calls exit (or die which is the same). Just provides a little more feedback to the calling script.

@luisrudge luisrudge self-requested a review September 21, 2019 02:50
@joshcanhelp joshcanhelp merged commit ac8afff into master Sep 24, 2019
@joshcanhelp joshcanhelp deleted the remove-basic-settings branch September 24, 2019 14:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants