Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove class WP-Auth0 and move methods to functions #756

Merged
merged 17 commits into from
Dec 30, 2019

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Dec 20, 2019

Changes

  • Remove class WP_Auth0
  • Move WP_Auth0::ready() to wp_auth0_is_ready()
  • Move WP_Auth0::get_tenant_region() to wp_auth0_get_tenant_region()
  • Move WP_Auth0::get_tenant() to wp_auth0_get_tenant()
  • Move WP_Auth0::render_back_to_auth0() to WP_Auth0_Lock::render_back_to_lock()

Note to reviewers: This PR is piecing the WP_Auth0 class into functions. I would recommend going commit by commit for this review. The diff for WP_Auth0.php did not come out well so if you're looking at the changed file, lines ~40 - 285 are all new.

Testing

  • This change adds unit test coverage
  • This change has been tested on WP5.3

Checklist

  • All existing and new tests complete without errors
  • All code quality tools/guidelines in the Contribution guide have been run/followed
  • All active GitHub CI checks have passed

@joshcanhelp joshcanhelp changed the title Remove deprecated from wp auth0 Remove class WP-Auth0 and move methods to functions Dec 20, 2019
@joshcanhelp joshcanhelp added this to the 4.0.0 milestone Dec 20, 2019
@joshcanhelp joshcanhelp force-pushed the remove-deprecated-from-wp-auth0 branch from 2262c82 to 9a9fc0c Compare December 20, 2019 20:15
@joshcanhelp joshcanhelp marked this pull request as ready for review December 21, 2019 01:29
@joshcanhelp joshcanhelp requested a review from a team December 21, 2019 01:29
@joshcanhelp joshcanhelp merged commit 3d9a497 into master Dec 30, 2019
@joshcanhelp joshcanhelp deleted the remove-deprecated-from-wp-auth0 branch December 30, 2019 21:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants