Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update Embedded settings validation and defaults #776

Merged
merged 1 commit into from
Feb 3, 2020
Merged

Update Embedded settings validation and defaults #776

merged 1 commit into from
Feb 3, 2020

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Jan 31, 2020 •
edited
Loading

Description

  • Normalize settings validation for the Embedded tab
  • Normalize defaults for the Embedded tab
  • Update Lock from 11.16.x to 11.21.x
  • Update Auth0.js from 9.10 to 9.12

References

WP guidance on sanitization and escaping

Testing

  • This change improves test coverage for new/changed/fixed functionality

@joshcanhelp joshcanhelp force-pushed the update-embedded-settings-validation branch from a70a539 to 0f9fc59 Compare February 3, 2020 17:08
@joshcanhelp joshcanhelp marked this pull request as ready for review February 3, 2020 17:10
@joshcanhelp joshcanhelp requested a review from a team February 3, 2020 17:10
@joshcanhelp joshcanhelp added this to the 4.0.0 milestone Feb 3, 2020
@joshcanhelp joshcanhelp merged commit 58d8c26 into master Feb 3, 2020
@joshcanhelp joshcanhelp deleted the update-embedded-settings-validation branch February 3, 2020 17:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@joshcanhelp @lbalmaceda