Fix loading document type attributes from DynamoDB when when saveUnknown=true #339
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue when using
saveUnknown
+useDocumentTypes
and trying to retrieve a model that hasn't yet been "used" for example:This is because since the Cat schema doesn't have
getProperties
attributeSchema.parseDynamo
will create an new attribute with anObject
type becauseAttribute.lookupType
returnsObject
for Dynamo "'M" types.This then causes the
Attribute.parseDynamo
to be parsed usingJSON.parse
instead of the correctmapify
.Interestingly this error doesn't happen if the model has been used to create (or put/save) before doing get/query/scan.
This is because when
Cat.create
runs, it creates thepetProperties
attribute in the model's schema, and whenCat.get
runs,Schema.parseDynamo
see that is haspetProperties
and doesn't try to create a new, incorrectly-typedAttribute
.