Change QueryKey and ScanKey type to any #419
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method startAt requires an object with the same format as the one given by the lastKey value not a String
Summary:
The type definition is incorrect for the types QueryKey and ScanKey since these two types are used for the startAt function.
The startAt key expects an object with the same format as the one given by the lastKey field when executing a query or scan and currently it was asking for a String which is causing a problem when trying to send the value.
There was a workaround for this using:
But that's just not OK.
Code sample:
This should work now:
Type (select 1):
Is this a breaking change? (select 1):
Is this ready to be merged into Dynamoose? (select 1):
Are all the tests currently passing on this PR? (select 1):
Other:
npm test
from the root of the project directory to ensure all tests continue to pass