From 445f1e29f4ba550ac2b31d0c7b6e9f498db80930 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E3=81=82=E3=81=A7?= <adelaide@fiberplane.com>
Date: Fri, 17 Nov 2023 14:13:51 +0100
Subject: [PATCH] Small fixes for examples & pr template

---
 .github/pull_request_template.md                  |  2 +-
 examples/export_metrics/{otlp.py => otlp-grpc.py} | 12 ++++++++++++
 examples/export_metrics/otlp-http.py              | 11 +++++++++++
 3 files changed, 24 insertions(+), 1 deletion(-)
 rename examples/export_metrics/{otlp.py => otlp-grpc.py} (55%)

diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
index 88a32f9..f923ec7 100644
--- a/.github/pull_request_template.md
+++ b/.github/pull_request_template.md
@@ -9,6 +9,6 @@
 - [ ] Create test cases
 - [ ] Update changelog
 <!-- Use these for release PRs:
-- [ ] Update package version in `pyprojevt.toml`
+- [ ] Update package version in `pyproject.toml`
 - [ ] Update spec version in `constants.py`
 - [ ] Move changes to a new section in `CHANGELOG.md` -->
diff --git a/examples/export_metrics/otlp.py b/examples/export_metrics/otlp-grpc.py
similarity index 55%
rename from examples/export_metrics/otlp.py
rename to examples/export_metrics/otlp-grpc.py
index fd1e14d..b5f5e93 100644
--- a/examples/export_metrics/otlp.py
+++ b/examples/export_metrics/otlp-grpc.py
@@ -1,5 +1,9 @@
 import time
 from autometrics import autometrics, init
+from opentelemetry.sdk.metrics import Counter
+from opentelemetry.sdk.metrics.export import (
+    AggregationTemporality,
+)
 
 # Autometrics supports exporting metrics to OTLP collectors via gRPC and HTTP transports.
 # This example uses the gRPC transport, available settings are similar to the OpenTelemetry
@@ -10,7 +14,15 @@
 init(
     exporter={
         "type": "otlp-proto-grpc",
+        "endpoint": "http://localhost:4317",  # You don't need to set this if you are using the default endpoint
+        "insecure": True,  # Enabled for http transport
         "push_interval": 1000,
+        # Here are some other available settings:
+        # "timeout": 10,
+        # "headers": {"x-something": "value"},
+        # "aggregation_temporality": {
+        #     Counter: AggregationTemporality.CUMULATIVE,
+        # },
     },
     service_name="otlp-exporter",
 )
diff --git a/examples/export_metrics/otlp-http.py b/examples/export_metrics/otlp-http.py
index bacc835..6871e12 100644
--- a/examples/export_metrics/otlp-http.py
+++ b/examples/export_metrics/otlp-http.py
@@ -1,5 +1,9 @@
 import time
 from autometrics import autometrics, init
+from opentelemetry.sdk.metrics import Counter
+from opentelemetry.sdk.metrics.export import (
+    AggregationTemporality,
+)
 
 # Autometrics supports exporting metrics to OTLP collectors via gRPC and HTTP transports.
 # This example uses the HTTP transport, available settings are similar to the OpenTelemetry
@@ -10,7 +14,14 @@
 init(
     exporter={
         "type": "otlp-proto-http",
+        "endpoint": "http://localhost:4318/",  # You don't need to set this if you are using the default endpoint
         "push_interval": 1000,
+        # Here are some other available settings:
+        # "timeout": 10,
+        # "headers": {"x-something": "value"},
+        # "aggregation_temporality": {
+        #     Counter: AggregationTemporality.CUMULATIVE,
+        # },
     },
     service_name="otlp-exporter",
 )