Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Latency histogram query in Function Explorer dashboard does not use build_info fallback #77

Closed
brettimus opened this issue Jul 17, 2023 · 1 comment · Fixed by #78
Closed
Assignees

Comments

@brettimus
Copy link
Contributor

In the functions explorer grafana dashboard, the query here uses the following to left-join the build_info metric:

# Attach the `version` and `commit` labels from the `build_info` metric
      * on (instance, job) group_left(version, commit) last_over_time(build_info[$__rate_interval])

Whereas the request and error ratio use

 * on(instance, job) group_left(version, commit) (last_over_time(build_info[$__rate_interval]) or on (instance, job) up)

When I execute the latency query as specified, and build_info has not yet been observed, then I get no data back

image

When I use the fallback or on (instance, job) up, I get data:

image

@brettimus brettimus self-assigned this Jul 17, 2023
@brettimus
Copy link
Contributor Author

i'll pick this up, seems like a simple fix

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant