Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rename consensus engine from dummy to something else #616

Open
darioush opened this issue Aug 2, 2024 · 1 comment
Open

Rename consensus engine from dummy to something else #616

darioush opened this issue Aug 2, 2024 · 1 comment

Comments

@darioush
Copy link
Collaborator

darioush commented Aug 2, 2024

The name is a reference to "not implementing geth's consensus", but this is confusing to those who don't have the background on the name.
Since it's a bit odd to call production code dummy, let's rename it after finishing the geth update

@ceyonur
Copy link
Collaborator

ceyonur commented Aug 2, 2024

For some context: https://github.com/ava-labs/coreth/blob/master/consensus/dummy/README.md#L29

We can even consider removing that single dummy package and just use plain consensus pkg. If we prefer to keep, I think we can go with either something with verifier or avalanche/ava.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants