Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Do not relay messages that have already been delivered #22

Closed
cam-schultz opened this issue Aug 30, 2023 · 0 comments · Fixed by #23
Closed

Do not relay messages that have already been delivered #22

cam-schultz opened this issue Aug 30, 2023 · 0 comments · Fixed by #23
Assignees
@cam-schultz
Labels
enhancement New feature or request

Comments

@cam-schultz
Copy link
Collaborator

Context and scope
When #14 is implemented, it will be possible for relayers to attempt to relay messages that have already been delivered. We should first check if the message (as specificied by the origin chain ID and Teleporter message ID) has already been delivered, and stop early if so.

Discussion and alternatives
The most likely place for this will be in MessageManager:ShouldSendMessage
@cam-schultz cam-schultz added the enhancement New feature or request label Aug 30, 2023
@cam-schultz cam-schultz mentioned this issue Aug 30, 2023
Merged
@cam-schultz cam-schultz moved this from 📋 Backlog to 🔖 Ready in Avalanche Warp Messaging Aug 31, 2023
@cam-schultz cam-schultz moved this from 🔖 Ready to 🏗 In progress in Avalanche Warp Messaging Aug 31, 2023
@cam-schultz cam-schultz mentioned this issue Aug 31, 2023
Merged
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Avalanche Warp Messaging Sep 15, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@cam-schultz cam-schultz

Labels
enhancement New feature or request
Projects
Platform Engineering Group
Archived in project
Avalanche Warp Messaging
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check if message already delivered ava-labs/icm-services
1 participant
@cam-schultz