Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

No tests for unicode handling in Elm names #741

Open
emmabastas opened this issue Jul 6, 2021 · 1 comment
Open

No tests for unicode handling in Elm names #741

emmabastas opened this issue Jul 6, 2021 · 1 comment

Comments

@emmabastas
Copy link
Contributor

Elm names (i.e. variable, type, module, variant and port names) can contain unicode lower-/uppercase characters, but elm-format does not test for this in it's test suite.

What is lower and uppercase is determined by haskells Data.Char.isLower and Data.Char.isUpper (source: conversation with Evan)

@lydell
Copy link
Contributor

lydell commented Jul 6, 2021

I dug into this unicode stuff not too long ago. Here are some interesting links and regexes for this in case it is of interest:

https://github.com/rtfeldman/node-test-runner/blob/15deef63cc69f9968076353fa6af9c28d41fc1aa/lib/Parser.js#L229-L235

@avh4 avh4 added this to the 1.0.0 public release milestone Jul 13, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants