Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

stack overflow in memcached_fetch_result #53

Closed
m6w6 opened this issue Jan 20, 2020 · 1 comment
Closed

stack overflow in memcached_fetch_result #53

m6w6 opened this issue Jan 20, 2020 · 1 comment

Comments

@m6w6
Copy link
Collaborator

m6w6 commented Jan 20, 2020 •
edited
Loading

Imported from Launchpad using lp2gh.

In the binary protocol, we occasionally do a lot of ADDs without any GETs. Many of the ADDs already have values, and so return error messages. In that case, we end up with 7000+ error responses on the wire, and the recursive call in binary_read_one_response produces a stack overflow. It's trivial to fix with the included patch.
@m6w6 m6w6 added the New label Jan 20, 2020
@m6w6
Copy link
Collaborator Author

m6w6 commented Jan 20, 2020

@m6w6 m6w6 removed the New label Jan 20, 2020
@m6w6 m6w6 closed this as completed in 5dcfd87 Jan 21, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@m6w6