Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: add comma to set of special characters #78

Merged
merged 4 commits into from
Jun 29, 2020
Merged

fix: add comma to set of special characters #78

merged 4 commits into from
Jun 29, 2020

Conversation

Ikana
Copy link
Contributor

@Ikana Ikana commented Jun 17, 2020

Fixes: #77

This change makes it so the regular expression also matches commas

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Ikana Ikana changed the title add comma to set fix: add comma to set Jun 17, 2020
@piradeepk piradeepk self-requested a review June 24, 2020 23:05
@piradeepk piradeepk self-assigned this Jun 24, 2020
Copy link
Contributor

@piradeepk piradeepk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for making this fix @Ikana!

@piradeepk piradeepk changed the title fix: add comma to set fix: add comma to set of special characters Jun 29, 2020
@mergify mergify bot merged commit f04843b into aws-actions:master Jun 29, 2020
billputer referenced this pull request in billputer/configure-aws-credentials Jul 9, 2020
* master:
  chore: Update dist
  fix: Make tagging optional (#92)
  chore: Bump eslint from 7.3.1 to 7.4.0 (#94)
  chore: Update dist
  chore: Bump aws-sdk from 2.707.0 to 2.708.0 (#90)
  chore: update dependabot schedule (#89)
  chore(release): 1.4.2
  chore: Update dist
  chore: Bump aws-sdk from 2.706.0 to 2.707.0 (#88)
  chore: Switch to GitHub-native Dependabot
  chore: Update dist
  chore: Bump aws-sdk from 2.704.0 to 2.706.0
  chore: Update dist
  fix: add comma to set of special characters (#78)
  chore: Bump jest from 26.0.1 to 26.1.0
  chore: Update dist
  chore: Bump aws-sdk from 2.692.0 to 2.704.0
  chore: Bump eslint from 7.2.0 to 7.3.1
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comas on workflow name causes error
2 participants