From 74bd8f775c2b8731a7671b38a67b1db039e9f5f3 Mon Sep 17 00:00:00 2001
From: Kevin DeJong <kddejong@amazon.com>
Date: Wed, 8 Jan 2025 11:02:38 -0800
Subject: [PATCH] Don't fail when ignore templates is empty or not findable

---
 src/cfnlint/config.py                        |  9 +++++---
 test/unit/module/config/test_config_mixin.py | 22 ++++++++++++++++++++
 2 files changed, 28 insertions(+), 3 deletions(-)

diff --git a/src/cfnlint/config.py b/src/cfnlint/config.py
index a9f4aa5e4e..244d8df77f 100644
--- a/src/cfnlint/config.py
+++ b/src/cfnlint/config.py
@@ -785,9 +785,11 @@ def _ignore_templates(self):
         if isinstance(filenames, str):
             filenames = [filenames]
 
-        return self._glob_filenames(filenames)
+        return self._glob_filenames(filenames, False)
 
-    def _glob_filenames(self, filenames: Sequence[str]) -> list[str]:
+    def _glob_filenames(
+        self, filenames: Sequence[str], raise_exception: bool = True
+    ) -> list[str]:
         # handle different shells and Config files
         # some shells don't expand * and configparser won't expand wildcards
         all_filenames = []
@@ -796,7 +798,8 @@ def _glob_filenames(self, filenames: Sequence[str]) -> list[str]:
             add_filenames = glob.glob(filename, recursive=True)
 
             if not add_filenames and not self.ignore_bad_template:
-                raise ValueError(f"{filename} could not be processed by glob.glob")
+                if raise_exception:
+                    raise ValueError(f"{filename} could not be processed by glob.glob")
 
             all_filenames.extend(add_filenames)
 
diff --git a/test/unit/module/config/test_config_mixin.py b/test/unit/module/config/test_config_mixin.py
index 9e584ead07..cbed4b458e 100644
--- a/test/unit/module/config/test_config_mixin.py
+++ b/test/unit/module/config/test_config_mixin.py
@@ -247,6 +247,28 @@ def test_config_expand_ignore_templates(self, yaml_mock):
         )
         self.assertEqual(len(config.templates), 3)
 
+    @patch("cfnlint.config.ConfigFileArgs._read_config", create=True)
+    def test_config_expand_and_ignore_templates_with_bad_path(self, yaml_mock):
+        """Test ignore templates"""
+
+        yaml_mock.side_effect = [
+            {
+                "templates": ["test/fixtures/templates/bad/resources/iam/*.yaml"],
+                "ignore_templates": [
+                    "dne/fixtures/templates/bad/resources/iam/resource_*.yaml"
+                ],
+            },
+            {},
+        ]
+        config = cfnlint.config.ConfigMixIn([])
+
+        # test defaults
+        self.assertIn(
+            str(Path("test/fixtures/templates/bad/resources/iam/resource_policy.yaml")),
+            config.templates,
+        )
+        self.assertEqual(len(config.templates), 4)
+
     @patch("cfnlint.config.ConfigFileArgs._read_config", create=True)
     def test_config_merge(self, yaml_mock):
         """Test merging lists"""