From 25aa490fc2c07a1fab59969caffb1299f72edd98 Mon Sep 17 00:00:00 2001 From: Suraj Kota Date: Thu, 6 May 2021 20:00:54 +0000 Subject: [PATCH 1/2] refresh k8s client --- src/acktest/k8s/resource.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/acktest/k8s/resource.py b/src/acktest/k8s/resource.py index f5fed132..daf89567 100644 --- a/src/acktest/k8s/resource.py +++ b/src/acktest/k8s/resource.py @@ -113,8 +113,10 @@ def load_and_create_resource(resource_directory: Path, def _get_k8s_api_client() -> ApiClient: global _k8s_api_client - if _k8s_api_client is None: - _k8s_api_client = config.new_client_from_config() + # Create new client everytime to avoid token refresh issues + # https://github.com/kubernetes-client/python/issues/741 + # https://github.com/kubernetes-client/python-base/issues/125 + _k8s_api_client = config.new_client_from_config() return _k8s_api_client From 6648de431e5e18412f0ad6f6012dcc6aeb62c314 Mon Sep 17 00:00:00 2001 From: Suraj Kota Date: Thu, 6 May 2021 20:23:24 +0000 Subject: [PATCH 2/2] remove global var --- src/acktest/k8s/resource.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/acktest/k8s/resource.py b/src/acktest/k8s/resource.py index daf89567..76405609 100644 --- a/src/acktest/k8s/resource.py +++ b/src/acktest/k8s/resource.py @@ -26,8 +26,6 @@ from ..resources import load_resource_file -_k8s_api_client = None - @dataclass class CustomResourceReference: @@ -112,12 +110,10 @@ def load_and_create_resource(resource_directory: Path, return reference, spec, resource def _get_k8s_api_client() -> ApiClient: - global _k8s_api_client # Create new client everytime to avoid token refresh issues # https://github.com/kubernetes-client/python/issues/741 # https://github.com/kubernetes-client/python-base/issues/125 - _k8s_api_client = config.new_client_from_config() - return _k8s_api_client + return config.new_client_from_config() def create_k8s_namespace(namespace_name: str):