deprecate --service eks

Author: bwagner5

README.md

@@ -294,7 +294,7 @@ $ ec2-instance-selector --help
 ```
 
 ```bash#help
-ec2-instance-selector is a CLI tool to filter EC2 instance types based on resource criteria. 
+ec2-instance-selector is a CLI tool to filter EC2 instance types based on resource criteria.
 Filtering allows you to select all the instance types that match your application requirements.
 Full docs can be found at github.com/aws/amazon-ec2-instance-selector
 
@@ -378,7 +378,7 @@ Filter Flags:
 Suite Flags:
       --base-instance-type string   Instance Type used to retrieve similarly spec'd instance types
       --flexible                    Retrieves a group of instance types spanning multiple generations based on opinionated defaults and user overridden resource filters
-      --service string              Filter instance types based on service support (Example: eks, eks-20201211, or emr-5.20.0)
+      --service string              Filter instance types based on service support (Example: emr-5.20.0)
 
 
 Global Flags:

cmd/main.go

@@ -210,7 +210,7 @@ Full docs can be found at github.com/aws/amazon-` + binName
 
 	cli.SuiteStringFlag(instanceTypeBase, nil, nil, "Instance Type used to retrieve similarly spec'd instance types", nil)
 	cli.SuiteBoolFlag(flexible, nil, nil, "Retrieves a group of instance types spanning multiple generations based on opinionated defaults and user overridden resource filters")
-	cli.SuiteStringFlag(service, nil, nil, "Filter instance types based on service support (Example: eks, eks-20201211, or emr-5.20.0)", nil)
+	cli.SuiteStringFlag(service, nil, nil, "Filter instance types based on service support (Example: emr-5.20.0)", nil)
 
 	// Configuration Flags - These will be grouped at the bottom of the help flags
 
@@ -242,6 +242,10 @@ Full docs can be found at github.com/aws/amazon-` + binName
 		os.Exit(0)
 	}
 
+	if flags[service] != nil {
+		log.Println("--service eks is deprecated. EKS generally supports all instance types")
+	}
+
 	sess, err := getRegionAndProfileAWSSession(cli.StringMe(flags[region]), cli.StringMe(flags[profile]))
 	if err != nil {
 		fmt.Println(err)

pkg/selector/eks.go

@@ -59,14 +59,13 @@ func (sr *ServiceRegistry) Register(name string, service Service) {
 
 // RegisterAWSServices registers the built-in AWS service filter transforms
 func (sr *ServiceRegistry) RegisterAWSServices() {
-	sr.Register("eks", &EKS{})
 	sr.Register("emr", &EMR{})
 }
 
 // ExecuteTransforms will execute the ServiceRegistry's registered service filter transforms
 // Filters.Service will be parsed as <service-name>-<version> and passed to Service.Filters
 func (sr *ServiceRegistry) ExecuteTransforms(filters Filters) (Filters, error) {
-	if filters.Service == nil || *filters.Service == "" {
+	if filters.Service == nil || *filters.Service == "" || *filters.Service == "eks" {
 		return filters, nil
 	}
 	serviceAndVersion := strings.ToLower(*filters.Service)