Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

RDS: Database Cluster Writer/Reader's DeleteAutomatedBackups #25948

Open
2 tasks
argarinpauljohn opened this issue Jun 13, 2023 · 5 comments
Open
2 tasks

RDS: Database Cluster Writer/Reader's DeleteAutomatedBackups #25948

argarinpauljohn opened this issue Jun 13, 2023 · 5 comments
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@argarinpauljohn
Copy link

Describe the feature

In the original instance_props, there was a delete_automated_backups property. How can we specify that in writer/readers? The rds.ClusterInstance.provisioned method doesn't seem to support that.

Related issue: #25898

Use Case

We need to specify this without using escape hatches.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.82.1

Environment details (OS name and version, etc.)

macOS Ventura 13.3.1

@argarinpauljohn argarinpauljohn added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 13, 2023
@github-actions github-actions bot added the @aws-cdk/aws-rds Related to Amazon Relational Database label Jun 13, 2023
@peterwoodworth
Copy link
Contributor

Adding this here for clarity without having to check the other thread: We don't provide an option to set this with the new writer/reader API. Will need to use escape hatches in the meantime to add this prop

We accept contributions, adding this prop should be pretty easy 🙂

@peterwoodworth peterwoodworth added good first issue Related to contributions. See CONTRIBUTING.md p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jun 13, 2023
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@peterwoodworth
Copy link
Contributor

@argarinpauljohn was there any reason you closed this?

@argarinpauljohn
Copy link
Author

Oh sorry @peterwoodworth! Mistakenly closed this one. I won't have time to work on this at the moment though.

@corymhall
Copy link
Contributor

@argarinpauljohn based on the docs this property is not actually used for aurora clusters.

Amazon Aurora
Not applicable. When you delete a DB cluster, all automated backups for that DB cluster are deleted and can't be recovered. Manual DB cluster snapshots of the DB cluster are not deleted.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
3 participants