cli: cdk migrate wrongly converts casing in ecs task definition props

[tmokmss]

Describe the bug

cdk migrate fails in handling the casing of ECS task definition properties. See the reproduction steps below.

Expected Behavior

casing is kept from the original template.

          logConfiguration: {
            options: {
              awslogs-group: '/aws/ecs/test/main',
              awslogs-region: 'ap-northeast-1',
              awslogs-stream-prefix: 'ecs',
            },
            logDriver: 'awslogs',
          },

Current Behavior

they're converted to camel case.

          logConfiguration: {
            secretOptions: [
            ],
            options: {
              awslogsGroup: '/aws/ecs/test/main',
              awslogsRegion: 'ap-northeast-1',
              awslogsStreamPrefix: 'ecs',
            },
            logDriver: 'awslogs',
          },

It results in the error below when you try to deploy the template:

Resource handler returned message: "Invalid request provided: Create TaskDefinition: Log driver awslogs requires options: awslogs-region, awslogs-group (Service: AmazonECS; Status Code: 400
; Error Code: ClientException; ...

Reproduction Steps

Deploy this template from CFn management console:

AWSTemplateFormatVersion: '2010-09-09'

Resources:
  BackendECSTaskRole:
    Type: AWS::IAM::Role
    Properties:
      Path: /
      AssumeRolePolicyDocument:
        Statement:
          - Action: sts:AssumeRole
            Effect: Allow
            Principal:
              Service: ecs-tasks.amazonaws.com

  ECSTaskExecutionRole:
    Type: AWS::IAM::Role
    Properties:
      Path: /
      AssumeRolePolicyDocument:
        Statement:
          - Action: sts:AssumeRole
            Effect: Allow
            Principal:
              Service: ecs-tasks.amazonaws.com
      ManagedPolicyArns:
        - arn:aws:iam::aws:policy/service-role/AmazonECSTaskExecutionRolePolicy
        - arn:aws:iam::aws:policy/AmazonSSMReadOnlyAccess
        - arn:aws:iam::aws:policy/SecretsManagerReadWrite

  BackendServiceECSTaskDefinition:
    Type: AWS::ECS::TaskDefinition
    Properties:
      Family: test
      RequiresCompatibilities:
        - FARGATE
      Memory: "1024"
      Cpu: "256"
      NetworkMode: awsvpc
      ExecutionRoleArn: !GetAtt ECSTaskExecutionRole.Arn
      TaskRoleArn: !GetAtt BackendECSTaskRole.Arn
      ContainerDefinitions:
        - Name: "main"
          Image: "nginx"
          LogConfiguration:
            Options:
              awslogs-group: '/aws/ecs/test/main'
              awslogs-region: ap-northeast-1
              awslogs-stream-prefix: ecs
            LogDriver: awslogs

And then use cdk migrate:

npx cdk@latest migrate --from-stack --stack-name xxx

Possible Solution

No response

Additional Information/Context

There are some props in CFn that casing should remain unchanged. One of them is an object of string that takes any string as a key: example

CDK CLI Version

2.126.0

Framework Version

No response

Node.js Version

v20.10.0

OS

macOS

Language

TypeScript

Language Version

No response

Other information

No response

[tim-finnigan]

Thanks for reporting, I could reproduce the issue. It looks like the options need to remain in that format to deploy properly:

logConfiguration: {
  options: {
    'awslogs-group': '/aws/ecs/test/main',
    'awslogs-region': 'ap-northeast-1',
    'awslogs-stream-prefix': 'ecs',
  },
  logDriver: 'awslogs',
},

[TheRealAmazonKendra]

Duplicate-ish of #28997. Same issue in the code, different manifestation of the bug.

[TheRealAmazonKendra]

This fix for this was released in v2.132.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.