Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

aws-redshiftserverless: Add Max RPU Support #29259

Closed
2 tasks
IkeNefcy opened this issue Feb 26, 2024 · 5 comments
Closed
2 tasks

aws-redshiftserverless: Add Max RPU Support #29259

IkeNefcy opened this issue Feb 26, 2024 · 5 comments
Labels
@aws-cdk/aws-redshiftserverless Related to AWS Redshift Serverless effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. p2

Comments

@IkeNefcy
Copy link

IkeNefcy commented Feb 26, 2024

Describe the feature

Opening this early. Related: aws-cloudformation/cloudformation-coverage-roadmap#1844
Feature likely doesn't already exist due to no CFN support. If anyone wants to help make it a priority for CFN team that would be helpful. (add 👍 to issue above)

Use Case

Despite there being no support, the CDK deployment still overwrites any manually added max RPU value, which makes this a vital feature for CI/CD.

Proposed Solution

Once this issue is resolved aws-cloudformation/cloudformation-coverage-roadmap#1844,
please add Max RPU support in CDK.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.128.0

Environment details (OS name and version, etc.)

MacBook Pro M2

@IkeNefcy IkeNefcy added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 26, 2024
@github-actions github-actions bot added the @aws-cdk/aws-appsync Related to AWS AppSync label Feb 26, 2024
@IkeNefcy
Copy link
Author

Looks like there is no aws-redshiftserverless tag. Bot is confused.

@tim-finnigan tim-finnigan self-assigned this Feb 26, 2024
@tim-finnigan tim-finnigan added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Feb 26, 2024
@tim-finnigan
Copy link

Thanks for the feature request. I'll add the appropriate labels here. Others can add a 👍 to aws-cloudformation/cloudformation-coverage-roadmap#1844 to help with visibility.

@tim-finnigan tim-finnigan added p2 needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. @aws-cdk/aws-redshiftserverless Related to AWS Redshift Serverless effort/medium Medium work item – several days of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. @aws-cdk/aws-appsync Related to AWS AppSync labels Feb 26, 2024
@tim-finnigan tim-finnigan removed their assignment Feb 26, 2024
@IkeNefcy
Copy link
Author

IkeNefcy commented Mar 18, 2024

@tim-finnigan Hey, the issue I mentioned for CFN has been updated. The Max Capacity option has been added. I ran a test with my gamma env and it worked just fine editing the redshift serverless wg capacity.
Syntax added here https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-redshiftserverless-workgroup.html.
Updating so you know that this CDK ticket is viable to be worked whenever the team gets a chance (might even already be in from what I'm seeing). Thanks again.

@IkeNefcy
Copy link
Author

IkeNefcy commented Mar 18, 2024

The Max capacity has been updated in the docs here https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_redshiftserverless.CfnWorkgroup.html
But when inspecting the interface CfnWorkgroupProps{} it looks like this isn't actually added yet.
Looks like this is due to the construct being L1.

@IkeNefcy IkeNefcy closed this as completed Apr 8, 2024
Copy link

github-actions bot commented Apr 8, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
@aws-cdk/aws-redshiftserverless Related to AWS Redshift Serverless effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. p2
Projects
None yet
Development

No branches or pull requests

2 participants