aws-cdk-lib/aws-rds/DatabaseCluster: DatabaseCluster.instanceEndpoints does not return writer endpoints

[steffenjambit]

Describe the bug

The DatabaseCluster.instanceEndpoints only returns the reader endpoints but not the writer endpoints, while DatabaseCluster.instanceIdentifiers returns identifiers for both.

Expected Behavior

According to the documentation I would expect both endpoints return the information for all instances:

i.e. DatabaseCluster.instanceEndpoints should return writer and reader endpoints.

Current Behavior

DatabaseCluster.instanceEndpoints only returns the reader endpoints but not the writer endpoints

Reproduction Steps

const clusterProps:DatabaseClusterProps = {
     …,
     writer: ClusterInstance.serverlessV2('writer'),
     readers: [ClusterInstance.serverlessV2('reader')],
     …
};

databaseCluster = new DatabaseCluster(
    this,
   `${id}`,
     {
       ...clusterProps,
        credentials: Credentials.fromSecret(secret),
     },
);

databaseCluster.instanceEndpoints

Possible Solution

the writer endpoint should be added to instanceEndpoints here:

aws-cdk/packages/aws-cdk-lib/aws-rds/lib/cluster.ts

Line 716 in f3d74bb

instanceIdentifiers.push(writer.instanceIdentifier);

Additional Information/Context

No response

CDK CLI Version

2.130.0

Framework Version

No response

Node.js Version

v18.17.1

OS

Mac

Language

TypeScript

Language Version

No response

Other information

No response

[pahud]

According to this

aws-cdk/packages/aws-cdk-lib/aws-rds/lib/cluster.ts

Lines 718 to 733 in f3d74bb

	(props.readers ?? []).forEach(instance => {
	const clusterInstance = instance.bind(this, this, {
	monitoringInterval: props.monitoringInterval,
	monitoringRole: monitoringRole,
	removalPolicy: props.removalPolicy ?? RemovalPolicy.SNAPSHOT,
	subnetGroup: this.subnetGroup,
	});
	readers.push(clusterInstance);
	if (clusterInstance.tier < 2) {
	this.validateReaderInstance(writer, clusterInstance);
	}
	instanceEndpoints.push(new Endpoint(clusterInstance.dbInstanceEndpointAddress, this.clusterEndpoint.port));
	instanceIdentifiers.push(clusterInstance.instanceIdentifier);
	});
	this.validateClusterInstances(writer, readers);

Only reader endpoints are returned and writer's is missing.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.