Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CodeBuild: new Fleet properties #30458

Closed
1 of 2 tasks
nmussy opened this issue Jun 5, 2024 · 4 comments
Closed
1 of 2 tasks

CodeBuild: new Fleet properties #30458

nmussy opened this issue Jun 5, 2024 · 4 comments
Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p3

Comments

@nmussy
Copy link
Contributor

nmussy commented Jun 5, 2024

Describe the feature

After I initially implemented the Fleet L2 construct in #29754, CloudFormation added support for the following three properties, which should be added to the L2:

Use Case

Match L2 coverage with newly added Cfn properties

Proposed Solution

No response

Other Information

Originally reported by @rgoltz in #29617 (comment)

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.144.0

Environment details (OS name and version, etc.)

N/A

@nmussy nmussy added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 5, 2024
@github-actions github-actions bot added the @aws-cdk/aws-codebuild Related to AWS CodeBuild label Jun 5, 2024
@pahud pahud added p3 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jun 7, 2024
@pahud
Copy link
Contributor

pahud commented Jun 7, 2024

Thank you!

@nmussy
Copy link
Contributor Author

nmussy commented Dec 17, 2024

Updated the issue to also include the recently(ish) added ScalingConfiguration from about a month ago, see #32175 (comment).

I'll open a PR for all three props some time this week

@nmussy
Copy link
Contributor Author

nmussy commented Dec 18, 2024

I've already opened a PR for another missing attribute #32574. For ease of review, it's probably best that I split each property into their own PR. It made a little more sense to group them when this issue was first opened, as there were only two missing fields. Closing this issue, but I'll reference it in each future PR

Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p3
Projects
None yet
Development

No branches or pull requests

3 participants