aws-ecs: ContainerImage.fromEcrRepository should be tagOrDigest
#30463
Labels
@aws-cdk/aws-ecs
Related to Amazon Elastic Container
bug
This issue is a bug.
documentation
This is a problem with documentation.
effort/small
Small work item – less than a day of effort
p3
Comments
cheruvian
added
documentation
cheruvian
changed the title
ContainerImage.fromEcrRepository should be tagOrDigestContainerImage.fromEcrRepository should be tagOrDigest
|
Yes, but I am not sure how to fix that without breaking changes. Any ideas? |
pahud
added
effort/small
|
Looks like it's a positional argument not a named one, so shouldn't be a breaking change? (unless this is some breaking change quirk of JSII?) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Describe the issue
The underlying
EcrImageconstructor has the correct namingtagOrDigestsince most use the helper static method the name and documentation should be updated there is as well.https://github.com/aws/aws-cdk/blob/v2.144.0/packages/aws-cdk-lib/aws-ecs/lib/images/ecr.ts#L22
Links
https://github.com/aws/aws-cdk/blob/v2.144.0/packages/aws-cdk-lib/aws-ecs/lib/container-image.ts#L22
https://github.com/aws/aws-cdk/blob/v2.144.0/packages/aws-cdk-lib/aws-ecs/lib/images/ecr.ts#L22
The text was updated successfully, but these errors were encountered: