Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Network Firewall: L1 construct don't have any way to add Customer managed key #30585

Closed
huyhoang160593 opened this issue Jun 19, 2024 · 3 comments
Labels
@aws-cdk/aws-kms Related to AWS Key Management bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. p3 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Comments

@huyhoang160593
Copy link

Describe the bug

like the title said

Expected Behavior

provide some property like kmsKeyId or somethings to add kms key to construct

Current Behavior

There is no option to define which Key to use in the struct

Reproduction Steps

The documentation don't have that option whatsoever

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.143.0

Framework Version

No response

Node.js Version

20.10.0

OS

Linux

Language

TypeScript

Language Version

No response

Other information

No response

@huyhoang160593 huyhoang160593 added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jun 19, 2024
@github-actions github-actions bot added the @aws-cdk/aws-kms Related to AWS Key Management label Jun 19, 2024
@pahud
Copy link
Contributor

pahud commented Jun 19, 2024

Are you looking for a property for customer managed key in AWS::NetworkFirewall::Firewall ? If yes, this would be a cloudformation gap and please help the CFN team prioritize by submitting an issue to https://github.com/aws-cloudformation/cloudformation-coverage-roadmap/issues

@pahud pahud added needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. p3 effort/medium Medium work item – several days of effort response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed needs-triage This issue or PR still needs to be triaged. labels Jun 19, 2024
Copy link

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Jun 21, 2024
@github-actions github-actions bot added closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jun 26, 2024
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
@aws-cdk/aws-kms Related to AWS Key Management bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. p3 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Development

No branches or pull requests

3 participants