fix(stepfunctions): allow disable x-ray #30808
Conversation
github-actions
bot
added
p2
distinguished-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
| // stateMachine.grantRead(role); | ||
| // stateMachine.grant(role, 'states:SendTaskSuccess'); | ||
|
|
||
| app.synth(); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| // stateMachine.grantRead(role); | ||
| // stateMachine.grant(role, 'states:SendTaskSuccess'); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| // const role = new iam.Role(stack, 'Role', { | ||
| // assumedBy: new iam.ServicePrincipal('lambda.amazonaws.com'), | ||
| // }); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| /* | ||
| * Stack verification steps: | ||
| * | ||
| * -- aws stepfunctions describe-state-machine --state-machine-arn <stack-output> has a status of `ACTIVE` | ||
| * -- aws iam get-role-policy --role-name <role-name> --policy-name <policy-name> has all actions mapped to respective resources. | ||
| */ |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| @@ -0,0 +1,25 @@ | |||
| import * as iam from 'aws-cdk-lib/aws-iam'; | |||
| import * as cdk from 'aws-cdk-lib'; | |||
| import * as sfn from 'aws-cdk-lib/aws-stepfunctions'; | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-community-review
|
@ChakshuGupta13 |
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-community-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #30796 .
Reason for this change
Description of changes
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license