Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

aws_codebuild: missing property for using a GitHub App credential type defined in CodeConnections #31236

Open
2 tasks
garysassano opened this issue Aug 28, 2024 · 2 comments
Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@garysassano
Copy link

garysassano commented Aug 28, 2024

Describe the feature

There's currently no way in CDK to configure a GitHub App as credential type:

image

Use Case

See above.

Proposed Solution

No response

Other Information

Related issue for Terraform AWS Provider: hashicorp/terraform-provider-aws#39011

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.154.1

Environment details (OS name and version, etc.)

Ubuntu 22.04.3 LTS

@garysassano garysassano added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 28, 2024
@github-actions github-actions bot added the @aws-cdk/aws-codebuild Related to AWS CodeBuild label Aug 28, 2024
@ashishdhingra ashishdhingra self-assigned this Aug 28, 2024
@ashishdhingra ashishdhingra added p2 investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Aug 28, 2024
@ashishdhingra
Copy link
Contributor

@garysassano Good afternoon. Please confirm the following:

Looks like the Auth Type GITHUBAPP (or something similar) is not yet available in CloudFormation per AWS::CodeBuild::Project SourceAuth. Please open a new issue at https://github.com/aws-cloudformation/cloudformation-coverage-roadmap so that it could be handled by CloudFormation team.

Thanks,
Ashish

@ashishdhingra ashishdhingra added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Aug 29, 2024
@garysassano
Copy link
Author

It seems the property is already available in CfnProject as the CODECONNECTIONS type (GitHub App is actually a connection defined in CodeConnections). However, since this is an L1 construct, it isn't very user-friendly.

To implement this feature as an L2 construct, I believe you should probably extend the existing GitHubSourceCredentials by adding an alternative codeConnections property, allowing users to use that instead of the accessToken.

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Aug 30, 2024
@ashishdhingra ashishdhingra added effort/medium Medium work item – several days of effort and removed needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. labels Sep 5, 2024
@ashishdhingra ashishdhingra removed their assignment Sep 5, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

2 participants