-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(appsync): lambda authorizer permission is not scoped to appsync api arn #31567
Merged
mergify
merged 8 commits into
aws:main
from
paulhcsun:appsycn-graphqlapi-lambda-permision
Sep 27, 2024
Merged
fix(appsync): lambda authorizer permission is not scoped to appsync api arn #31567
mergify
merged 8 commits into
aws:main
from
paulhcsun:appsycn-graphqlapi-lambda-permision
Sep 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-maintainer-review
This PR needs a review from a Core Team Member
label
Sep 27, 2024
moelasmar
approved these changes
Sep 27, 2024
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
This PR needs a review from a Core Team Member
label
Sep 27, 2024
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #31550.
Reason for this change
When using a lambda authorizer with a GraphqlAPI, the cdk automatically creates the AWS::Lambda::Permission required for the AppSync API to invoke the lambda authorizer. It does not however add a SourceArn.
This conflicts with the control tower policy [CT.LAMBDA.PR.2], and it is in general good practice to scope permissions.
Description of changes
Added new feature flag
APPSYNC_GRAPHQLAPI_SCOPE_LAMBDA_FUNCTION_PERMISSION
.Currently, when using a Lambda authorizer with an AppSync GraphQL API, the AWS CDK automatically generates the necessary AWS::Lambda::Permission to allow the AppSync API to invoke the Lambda authorizer. This permission is overly permissive because it lacks a SourceArn, meaning it allows invocations from any source.
When this feature flag is enabled, the AWS::Lambda::Permission will be properly scoped with the SourceArn corresponding to the specific AppSync GraphQL API.
Description of how you validated changes
Unit + integ tests with feature flag enabled.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license