-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(cli): lambda hotswap fails if lambda:GetFunctionConfiguration
action is not allowed
#32301
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32301 +/- ##
=======================================
Coverage 77.46% 77.46%
=======================================
Files 105 105
Lines 7168 7168
Branches 1314 1314
=======================================
Hits 5553 5553
Misses 1433 1433
Partials 182 182
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lambda:GetFunctionConfiguration
action is not allowed lambda:GetFunctionConfiguration
action is not allowed
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Closes #32219
Reason for this change
In SDKv3, the standard
waitUntilFunctionUpdated
function invokes theGetFunctionConfiguration
API, as opposed to SDKv2, which invokedGetFunction
. This means that consumers of SDKv3 must allow thelambda:GetFunctionConfiguration
action in their IAM role policy.Description of changes
Use a different waiter function provided by the SDK, which invokes
GetFunction
instead ofGetFunctionConfiguration
, and thus restoring required IAM permissions to what they were in SDKv2.See https://github.com/aws/aws-sdk-js-v3/blob/main/clients/client-lambda/src/waiters/waitForFunctionUpdatedV2.ts#L10
Description of how you validated changes
Manul test. Assumed a role with the following policies:
Then, run the CLI from the PR.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license