From 969177cb2de3566f528a89def594cc844858ca53 Mon Sep 17 00:00:00 2001 From: Smeb Date: Fri, 29 Mar 2024 12:46:15 +0100 Subject: [PATCH 1/2] fix typos in flagname, make test description accurate --- packages/aws-cdk/lib/cdk-toolkit.ts | 2 +- packages/aws-cdk/test/diff.test.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/aws-cdk/lib/cdk-toolkit.ts b/packages/aws-cdk/lib/cdk-toolkit.ts index e2614a3710aad..1e3341619ed51 100644 --- a/packages/aws-cdk/lib/cdk-toolkit.ts +++ b/packages/aws-cdk/lib/cdk-toolkit.ts @@ -183,7 +183,7 @@ export class CdkToolkit { let changeSet = undefined; if (options.changeSet) { - // only perform this check if we're going to make a changeset. This check requires permissions that --no-changeset users might not have. + // only perform this check if we're going to make a changeset. This check requires permissions that --no-change-set users might not have. const stackExists = await this.props.deployments.stackExists({ stack: stack, deployName: stack.stackName, diff --git a/packages/aws-cdk/test/diff.test.ts b/packages/aws-cdk/test/diff.test.ts index e120103390087..c55b77c429777 100644 --- a/packages/aws-cdk/test/diff.test.ts +++ b/packages/aws-cdk/test/diff.test.ts @@ -336,7 +336,7 @@ describe('non-nested stacks', () => { expect(exitCode).toBe(0); }); - test('diff does not check for stack existence when --no-changeset is passed', async () => { + test('diff does not check for stack existence when changeSet is false', async () => { // GIVEN const buffer = new StringWritable(); From 3b3e6933a3f32f994de9a5e92f0f8d1301e2e55a Mon Sep 17 00:00:00 2001 From: Parker Scanlon <69879391+scanlonp@users.noreply.github.com> Date: Thu, 4 Apr 2024 14:20:06 -0700 Subject: [PATCH 2/2] Update packages/aws-cdk/test/diff.test.ts --- packages/aws-cdk/test/diff.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/aws-cdk/test/diff.test.ts b/packages/aws-cdk/test/diff.test.ts index c55b77c429777..591311a184092 100644 --- a/packages/aws-cdk/test/diff.test.ts +++ b/packages/aws-cdk/test/diff.test.ts @@ -336,7 +336,7 @@ describe('non-nested stacks', () => { expect(exitCode).toBe(0); }); - test('diff does not check for stack existence when changeSet is false', async () => { + test('diff does not check for stack existence when --no-change-set is passed, async () => { // GIVEN const buffer = new StringWritable();